New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.5.x] Documentation - "Serialization" page grammar improvements. #2511
[1.5.x] Documentation - "Serialization" page grammar improvements. #2511
Conversation
Improved sentence structure and tense errors in the documentation. The goal was to preserve the meaning, while improving readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @BillyAutrey, thanks!
Would it be possible for you to make the same improvements on the /java/guide
version of this same file (Lagom has each page in the docs duplicated)
Note to self (and maintainers): this PR targets |
Sure @ignasi35, I can add a commit for the Java docs. I can also look at the 1.6.x docs and add another PR for that. Should be a straightforward comparison. |
@BillyAutrey, you don't need to send another PR. Let me try to re-target this one. |
Hmm, didn't work. The best is to close it and send it to 1.6.x |
rebase the branch on top of |
The contents of the I think we're better off just targeting |
I was cmparing the changes in this PR with the contents on the |
I think this should be merged without forward-porting and without any changes on thanks @BillyAutrey ! |
I think this should be merged without forward-porting and without any changes on thanks @BillyAutrey ! |
Pull Request Checklist
Fixes
N/A
Purpose
Improves grammar and sentence structure in key places on the "Serialization" Scala page. Improves readability, without changing the content.