Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to frames version of javadocs #80

Merged
merged 1 commit into from
Apr 15, 2016

Conversation

jroper
Copy link
Member

@jroper jroper commented Apr 8, 2016

This changes every link to the javadocs to link to the frames version. In addition, it adds a small amount of javascript to each page that ensures that linking to specific method anchors in the javadocs still works.

@jroper
Copy link
Member Author

jroper commented Apr 8, 2016

Failing due to the markdownValidateDocs validation not being aware of the index.html?path/to/Class.html syntax, I'll have to update the lightbend markdown plugin.

This changes every link to the javadocs to link to the frames version.
In addition, it adds a small amount of javascript to each page that
ensures that linking to specific method anchors in the javadocs still
works.
@dotta
Copy link
Contributor

dotta commented Apr 15, 2016

lgtm

@jroper jroper merged commit de4fb70 into lagom:master Apr 15, 2016
@jroper jroper deleted the javadoc-improvements branch April 15, 2016 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants