Bumps to Lagom 1.4.1. Fixes some ExCtx issues #167
Conversation
| anonymizeBids(user, currency, bidHistory), user, currency, seller, winner, currentBidMaximum, bidResult, (Nav) nav)); | ||
| }, ec.current()); | ||
| }, ec.current()) | ||
| , ec.current()); |
There was a problem hiding this comment.
This huge change is mostly formatting. The interesting bit are the last two ec.current() added.
There was a problem hiding this comment.
I'm a little surprised that it needs to be added in so many places. I thought it would only be the render call that needs to run in that EC.
This whole thing could stand some refactoring I think... later
There was a problem hiding this comment.
This whole thing could stand some refactoring I think... later
Oh, it does!
| .thenApplyAsync(nav -> { | ||
| ctx().session().clear(); | ||
| return ok(views.html.index.render(nav)); | ||
| }, httpExecutionContext.current()); |
There was a problem hiding this comment.
All this change is formatting and a couple of ec.current() added in seldom methods.
|
I've done a rather extensive manual test of the (including search features). Keeping an eye on terminal logs too. With the changes suggested in this PR everything seems to work. Hmm, not sure I tested the login operation (I did test signup and logout, though). 🤔 |
|
Easier to review with the secret "ignore whitespace" URL: https://github.com/lagom/online-auction-java/pull/167/files?w=1 |
|
Login page is in fact broken |
|
It looks like the entire login function is broken. I suggest that we leave that out of this pull request. |
|
I pushed my WIP changes to the login controller, but the back-end service also needs to be fixed. |
|
Tests repeatedly timed out, so I increased the timeout duration. |
|
Thanks @TimMoore ! |
Bumps Lagom to 1.4.1.
While testing I noticed a couple of controllers failed because the CompletionStage composition required the explicit ExecutionContext.