Skip to content
This repository has been archived by the owner on May 9, 2019. It is now read-only.

Add conditional test run on elastic search #61

Merged
merged 1 commit into from Mar 16, 2017
Merged

Conversation

lakhina
Copy link
Contributor

@lakhina lakhina commented Mar 15, 2017

fixes #48

Copy link
Contributor

@TimMoore TimMoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

God job working through this, @lakhina and @yg-apaza!

Now that we're using sudo, we could also install using the deb package as described in https://docs.travis-ci.com/user/database-setup/#Installing-specific-versions-of-ElasticSearch

I think we can merge this as is, though, and save that change for a future improvement.

I'll leave this open for @ignasi35 to give a second opinion before merging.

@ignasi35
Copy link
Contributor

ignasi35 commented Mar 16, 2017

This looks great!

I will merge as is and create 2 issues:

@ignasi35 ignasi35 merged commit dda06e8 into lagom:master Mar 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants