refactor(website,cli,serverless): introduce production/preview deployments #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Previously, deployments were marked as "current" or "non-current". This PR makes it clear that a deployment can either be a production one, or a non-production one. The only difference is that production deployments are automatically assigned with the function's default domain and any additional domains. Both production and non-production deployments always have a subdomain assigned, which is the deployment id.
Following this logic, a new
--production(or--prod) option has been added tolagon deploy, which defaults tofalse.Also, "Rollback" has been renamed to "Promote" ("Promote to Production") to better match this new behavior.