refactor(js-runtime): use types from WebWorker API #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Use types from WebWorker API instead of relying on custom ones. This makes sure the interfaces are correct (but the implementation itself can still have bugs). I've added some new methods to comply with the types that aren't implemented in this PR and throw an error instead - it should be done in another PR.
process.argvshim has been moved to js-runtime directly, instead of being only in theastrointegration before.Also, all js-runtime code is now wrapped inside IIFE, to prevent leaking objects to the global scope.