Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add worker import condition #744

Merged
merged 1 commit into from Apr 9, 2023
Merged

Conversation

QuiiBz
Copy link
Member

@QuiiBz QuiiBz commented Apr 9, 2023

About

Relates to #743

vite-plugin-ssr has the following conditions:

Screenshot 2023-04-09 at 14 20 16

Since Lagon uses the browser platform to bundle using ESBuild, it tried to import the wrong file using the browser condition.

@changeset-bot
Copy link

changeset-bot bot commented Apr 9, 2023

🦋 Changeset detected

Latest commit: 964bc24

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lagon/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dashboard ❌ Failed (Inspect) Apr 9, 2023 0:25am
docs ✅ Ready (Inspect) Visit Preview Apr 9, 2023 0:25am
storybook ✅ Ready (Inspect) Visit Preview Apr 9, 2023 0:25am
www ✅ Ready (Inspect) Visit Preview Apr 9, 2023 0:25am

@QuiiBz QuiiBz merged commit e92fb57 into main Apr 9, 2023
5 of 6 checks passed
@QuiiBz QuiiBz deleted the fix/cli-worker-condition branch April 9, 2023 12:33
@QuiiBz QuiiBz mentioned this pull request Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant