Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runtime): support SubtleCrypto#deriveBits #839

Merged
merged 5 commits into from May 11, 2023

Conversation

akitaSummer
Copy link
Contributor

Hello, I am very interested in your project and I noticed that you need support for a deriveBits function. I have implemented a version here, would you like to see if it meets your requirements?

#787

@changeset-bot
Copy link

changeset-bot bot commented May 7, 2023

🦋 Changeset detected

Latest commit: 3c8904f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@lagon/runtime Patch
@lagon/cli Patch
@lagon/serverless Patch
@lagon/js-runtime Patch
@lagon/docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 4:42pm

@vercel
Copy link

vercel bot commented May 7, 2023

@akitaSummer is attempting to deploy a commit to the Lagon Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@QuiiBz QuiiBz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! #787 also includes deriveKeys, would you like to implement it?

We should also update the crypto table documentation: https://github.com/lagonapp/lagon/blob/main/packages/docs/pages/runtime-apis.mdx#crypto

Finally, could you run pnpm changeset at the root of the project to generate a changelog? See the documentation here

crates/runtime_v8_utils/src/lib.rs Outdated Show resolved Hide resolved
@akitaSummer
Copy link
Contributor Author

Thanks for this PR! #787 also includes deriveKeys, would you like to implement it?

I only have time on weekends, and if time permits, I will add the deriveKeys method. But please do not wait for me too long.

@QuiiBz
Copy link
Member

QuiiBz commented May 9, 2023

I only have time on weekends, and if time permits, I will add the deriveKeys method. But please do not wait for me too long.

Thanks! Let me know if you don't have the time, I'll implement it myself

@QuiiBz QuiiBz changed the title feat: support deriveBits feat(runtime): support SubtleCrypto#deriveBits May 11, 2023
Copy link
Member

@QuiiBz QuiiBz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated a bit the code and added deriveBits to the docs, thanks!

@QuiiBz QuiiBz merged commit 52b170a into lagonapp:main May 11, 2023
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants