Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runtime): support AES-CTR for SubtleCrypto#encrypt & SubtleCrypto#decrypt #863

Merged
merged 9 commits into from
May 14, 2023

Conversation

akitaSummer
Copy link
Contributor

@akitaSummer akitaSummer commented May 14, 2023

Closes #409

@changeset-bot
Copy link

changeset-bot bot commented May 14, 2023

🦋 Changeset detected

Latest commit: ec52476

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@lagon/cli Patch
@lagon/runtime Patch
@lagon/serverless Patch
@lagon/docs Patch
@lagon/js-runtime Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2023 3:11pm

@vercel
Copy link

vercel bot commented May 14, 2023

@akitaSummer is attempting to deploy a commit to the Lagon Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@QuiiBz QuiiBz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, I just have a small suggestion:

crates/runtime/tests/crypto.rs Show resolved Hide resolved
@QuiiBz QuiiBz changed the title feat(runtime): support AES-CTR for SubtleCrypto#encrypt & SubtleCrypto#decrypt feat(runtime): support AES-CTR for SubtleCrypto#encrypt & SubtleCrypto#decrypt May 14, 2023
Copy link
Member

@QuiiBz QuiiBz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again!

@QuiiBz QuiiBz enabled auto-merge (squash) May 14, 2023 15:13
@QuiiBz QuiiBz merged commit 4e6968a into lagonapp:main May 14, 2023
7 of 10 checks passed
@QuiiBz QuiiBz mentioned this pull request May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AES-CTR for SubtleCrypto#encrypt  & SubtleCrypto#decrypt
2 participants