Patch to allow configuring Wayland 'gtk-dialogs-use-header' #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, thanks! I forced push an amendment so the PKGBUILD checksums (for Arch) are up-to-date as part of the commit. |
lah7
approved these changes
Mar 7, 2023
|
Ah, thank-you (I did forget the PKGBUILD, I'm a NixOS user not Arch). |
ghost
deleted the
archlinux-github
pushed a commit
to archlinux/aur
that referenced
this pull request
Mar 7, 2023
For details: lah7/gtk3-classic#93
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
When upstream GTK added then Wayland backend a number of GTK settings values were prioritized to come from 'org.gnome.' dconf/gsettings. In the case where no applicable 'org.gnome' setting existed (to map to an applicable GTK setting) the GTK setting was hardcoded. One of these settings was 'gtk-dialogs-use-header' (hardcoded to TRUE). This setting controls where action buttons in dialogs (FileChooser/ColorChooser/etc.) appear (TRUE=in header bar, FALSE=in action area).
This patch removes the hardcoded value for this setting (on Wayland), allowing it to be set via settings.ini. Note, contrary to the hardcoded value in Wayland the default value is FALSE.