Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

Minor fixes in Github Releases documentation #73

Merged
merged 2 commits into from
Jun 20, 2015

Conversation

abesto
Copy link
Contributor

@abesto abesto commented Jun 19, 2015

I'm new to goxc so I'm just assuming -wcl should be -wc, like in the other examples.
I'm pretty sure the quotes should be normal quotes :)

@laher
Copy link
Owner

laher commented Jun 19, 2015

Good catch, but the correct option is -wlc. -wlc writes a different file
called .goxc.local.json
This is for better security practice, so you only save the api key locally,
whereas the rest of the config can be added into your source control file.

Background: goxc supports a 'heirarchy' of config files, so the contents of
.goxc.local.json overrides .goxc.json
The idea being that .goxc.json is stored in your repo for re-use, but
.goxc.local.json is git-ignored.
It's poorly documented, so I'll add a section to clarify that too.
Thanks for reporting

On Sat, Jun 20, 2015 at 8:01 AM, Zoltán Nagy notifications@github.com
wrote:

I'm new to goxc so I'm just assuming -wcl should be -wc, like in the
other examples.

I'm pretty sure the quotes should be normal quotes :)

You can view, comment on, or merge this pull request online at:

#73
Commit Summary

  • Minor fixes in Github Releases documentation

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#73.

@abesto
Copy link
Contributor Author

abesto commented Jun 19, 2015

Great, thanks. I re-pushed the commit with just the quotes.

@laher
Copy link
Owner

laher commented Jun 19, 2015

Sweet as, thanks. My bad for editing the readme from the browser.
It's not letting me merge until Travis finishes its thing, but I'll merge
it in shortly.
Funnily enough I only made the changes this week, and I haven't yet
thoroughly tested & announced the github-releases task.
It's a new feature which should make goxc much more interesting to a lot of
people. Hope you enjoy it

On Sat, Jun 20, 2015 at 8:24 AM, Zoltán Nagy notifications@github.com
wrote:

Great, thanks. I re-pushed the commit with just the quotes.


Reply to this email directly or view it on GitHub
#73 (comment).

@abesto
Copy link
Contributor Author

abesto commented Jun 19, 2015

I'm seriously impressed so far :) I just came across goxc and found this staring at me in the readme, and it's working great! It definitely cuts down on the whole release cycle time.

laher added a commit that referenced this pull request Jun 20, 2015
Minor fixes in Github Releases documentation
@laher laher merged commit f263a17 into laher:master Jun 20, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants