Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toc.py: move rtl setting to table attribute #34

Closed
kynikos opened this issue Mar 25, 2016 · 3 comments
Closed

toc.py: move rtl setting to table attribute #34

kynikos opened this issue Mar 25, 2016 · 3 comments

Comments

@kynikos
Copy link
Contributor

kynikos commented Mar 25, 2016

Do you think it would make sense to move the rtl script setting from L248 to a table attribute in the wiki docs, similar to what is done with data-toc-alsoin? ltr could be the default, and rtl mode would be used if the table has a data-toc-rtl="1" attribute.

@lahwaacz
Copy link
Owner

I'm not sure, after all it's a feature of the language, not the table. Perhaps moving it to ws.ArchWiki.lang instead would be better?

@kynikos
Copy link
Contributor Author

kynikos commented Mar 25, 2016

Yep, ws.ArchWiki.lang looks appropriate to me too, anyway of course the decision is ultimately up to you, it's just that storing that info in toc.py seems a bit out of place to me, but nothing too important after all.

@lahwaacz
Copy link
Owner

Of course you're completely right that it was out of place in toc.py, thanks for pointing it out. There are most likely many similar inconsistencies waiting to be revealed 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants