You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
I converted the spaces to tabs so it's not really clear here what I changed, the problem with the code was basically that some methods assumed to get (ip, port) tuples where they would get Node-objects and the other way around resulting in errors.
I changed most of the code to use Node-objects, also I fixed a condition where encodeNodes(nodes) could get called with Node-objetcs AND tuples by doing so.
622d66e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I converted the spaces to tabs so it's not really clear here what I changed, the problem with the code was basically that some methods assumed to get (ip, port) tuples where they would get Node-objects and the other way around resulting in errors.
I changed most of the code to use Node-objects, also I fixed a condition where encodeNodes(nodes) could get called with Node-objetcs AND tuples by doing so.