Update devcontainer names and scripts. Make root one work for all dev

LAION-AI · Feb 12, 2023 · f566220 · f566220
1 parent c7c396f
commit f566220
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 8 deletions.
diff --git a/.devcontainer/backend-dev/devcontainer.json b/.devcontainer/backend-dev/devcontainer.json
@@ -1,12 +1,12 @@
 {
-  "name": "Open-Assistant",
+  "name": "Backend Development",
   "image": "mcr.microsoft.com/vscode/devcontainers/universal",
   "features": {
     "ghcr.io/devcontainers-contrib/features/pre-commit:2": {
       "version": "latest"
     }
   },
-  "postCreateCommand": "bash .devcontainer/backend-dev/post_create_command.sh",
+  "postCreateCommand": ".devcontainer/backend-dev/post_create_command.sh",
   "customizations": {
     "vscode": {
       "extensions": ["GitHub.copilot"]

diff --git a/.devcontainer/backend-dev/post_create_command.sh b/.devcontainer/backend-dev/post_create_command.sh
@@ -1,3 +1,5 @@
+#!/bin/bash
+
 # ensure pre-commit is installed
 pre-commit install
 

diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
@@ -1,12 +1,12 @@
 {
-  "name": "Open-Assistant",
+  "name": "Generic",
   "image": "mcr.microsoft.com/vscode/devcontainers/universal",
   "features": {
     "ghcr.io/devcontainers-contrib/features/pre-commit:2": {
       "version": "latest"
     }
   },
-  "postCreateCommand": "bash .devcontainer/post_create_command.sh",
+  "postCreateCommand": ".devcontainer/post_create_command.sh",
   "customizations": {
     "vscode": {
       "extensions": ["GitHub.copilot"]

diff --git a/.devcontainer/frontend-dev/devcontainer.json b/.devcontainer/frontend-dev/devcontainer.json
@@ -1,12 +1,12 @@
 {
-  "name": "Open-Assistant",
+  "name": "Front-end Development",
   "image": "mcr.microsoft.com/vscode/devcontainers/universal",
   "features": {
     "ghcr.io/devcontainers-contrib/features/pre-commit:2": {
       "version": "latest"
     }
   },
-  "postCreateCommand": "bash .devcontainer/frontend-dev/post_create_command.sh",
+  "postCreateCommand": ".devcontainer/frontend-dev/post_create_command.sh",
   "customizations": {
     "vscode": {
       "extensions": ["GitHub.copilot"]

diff --git a/.devcontainer/frontend-dev/post_create_command.sh b/.devcontainer/frontend-dev/post_create_command.sh
@@ -1,3 +1,5 @@
+#!/bin/bash
+
 # ensure pre-commit is installed
 pre-commit install
 

diff --git a/.devcontainer/post_create_command.sh b/.devcontainer/post_create_command.sh
@@ -1,5 +1,9 @@
-# ensure pre-commit is installed
-pre-commit install
+#!/bin/bash
+
+# Run both backend-dev and frontend-dev post_create scripts
+
+./.devcontainer/backend-dev/post_create_command.sh
+./.devcontainer/frontend-dev/post_create_command.sh
 
 # run yarn install in docs folder
 cd docs