Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: when a frame has no more children, self should be considered as 100% #58

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

laixintao
Copy link
Owner

@laixintao laixintao commented Oct 19, 2023

close #57

@laixintao laixintao marked this pull request as ready for review October 19, 2023 03:50
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

Merging #58 (0c581d2) into main (e8cc9b8) will increase coverage by 0.00%.
Report is 4 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #58   +/-   ##
=======================================
  Coverage   97.49%   97.50%           
=======================================
  Files          15       15           
  Lines         998     1001    +3     
=======================================
+ Hits          973      976    +3     
  Misses         25       25           
Files Coverage Δ
flameshow/render/framedetail.py 94.88% <100.00%> (+0.46%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@laixintao laixintao merged commit 0c22a39 into main Oct 19, 2023
9 checks passed
@laixintao laixintao deleted the fix-self-child branch October 19, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: when a frame has no more children, self should be considered as 100%
2 participants