Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simpler more secure MAC calculation (CBOR array) #137

Closed
wants to merge 3 commits into from
Closed

Simpler more secure MAC calculation (CBOR array) #137

wants to merge 3 commits into from

Conversation

emanjon
Copy link
Collaborator

@emanjon emanjon commented Jul 26, 2021

No description provided.

This was referenced Jul 26, 2021
Closed
Closed
@emanjon emanjon mentioned this pull request Jul 26, 2021
Closed
@emanjon
Copy link
Collaborator Author

emanjon commented Jul 26, 2021

This is now a change bases on #136. The reader need to first look at #136 to understand the suggested changes to the main branch.

The diff gives a good overview of the difference between a sequence solution and a array solution.

If approved. #137 needs to be merged before #136.

@chrysn chrysn mentioned this pull request Jul 29, 2021
Merged
@emanjon
Copy link
Collaborator Author

emanjon commented Aug 3, 2021

Closing this, the plan is to merge #136

@emanjon emanjon closed this Aug 3, 2021
@emanjon emanjon deleted the Simpler-more-secure-MAC-calculation-(CBOR-array) branch August 19, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@emanjon