fix(list): cannot change a numbered list that includes an inline box …

…to another list
lakejs · May 17, 2024 · 77426bc · 77426bc
1 parent 63d359e
commit 77426bc
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 1 deletion.
diff --git a/src/operations/set-blocks.ts b/src/operations/set-blocks.ts
@@ -37,7 +37,8 @@ export function setBlocks(range: Range, value: string | KeyValue): void {
     return;
   }
   if (range.isCollapsed) {
-    if (range.isBox) {
+    const boxNode = range.commonAncestor.closest('lake-box');
+    if (boxNode.isBlockBox) {
       return;
     }
   }

diff --git a/src/plugins/list.ts b/src/plugins/list.ts
@@ -98,6 +98,7 @@ export default (editor: Editor) => {
         }
       }
       editor.history.save();
+      editor.selection.sync();
     },
   });
   editor.container.on('click', event => {

diff --git a/tests/plugins/list.test.ts b/tests/plugins/list.test.ts
@@ -1,5 +1,8 @@
 import { testPlugin } from '../utils';
 
+// const imageUrl = '../assets/images/heaven-lake-256.png';
+const imageBoxValue = 'eyJ1cmwiOiIuLi9hc3NldHMvaW1hZ2VzL2hlYXZlbi1sYWtlLTI1Ni5wbmciLCJzdGF0dXMiOiJkb25lIn0=';
+
 describe('plugins / list', () => {
 
   it('should change a paragraph to a numbered list', () => {
@@ -92,6 +95,24 @@ describe('plugins / list', () => {
     );
   });
 
+  it('should change a numbered list that includes an inline box to a bulleted list', () => {
+    const content = `
+    <ol><li>foo<lake-box type="inline" name="image" value="${imageBoxValue}" focus="end"></lake-box></li></ol>
+    <p>bar</p>
+    `;
+    const output = `
+    <ul><li>foo<lake-box type="inline" name="image" value="${imageBoxValue}" focus="end"></lake-box></li></ul>
+    <p>bar</p>
+    `;
+    testPlugin(
+      content,
+      output,
+      editor => {
+        editor.command.execute('list', 'bulleted');
+      },
+    );
+  });
+
   it('should change a numbered list to a checklist', () => {
     const content = `
     <ol><li>foo<focus /></li></ol>