Implement Flink ScanTableSource and LookupTableSource #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuChangHui
requested review from
xuchen-plus,
Ceng23333,
lypnaruto,
moresun,
F-PHantam and
dmetasoul01
YuChangHui
added
enhancement
Ceng23333
reviewed
May 11, 2023
| <groupId>org.apache.flink</groupId> | ||
| <artifactId>flink-csv</artifactId> | ||
| <version>${flink.version}</version> | ||
| </dependency> |
There was a problem hiding this comment.
Is flink-csv neccesary?
There was a problem hiding this comment.
Is flink-csv neccesary?
flink sqlclient exports parquet as csv file by flink-csv for k8s test
Ceng23333
reviewed
May 11, 2023
| <artifactId>spark-sql_2.12</artifactId> | ||
| <version>3.3.1</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| </dependencies> |
There was a problem hiding this comment.
Is is necessary for importing a full spark-sql_2.12 package for test?
…bleSource && mock lookup cache for test
…tition value pushdown
…& LookupTableSource supports reading latest N partitions, sort order is partition name
…ionReader.read && update CHBenchmark、LookupJoinCase
Ceng23333
reviewed
May 11, 2023
| FlinkUtil.setFSConfigs(conf, reader); | ||
| reader.initializeReader(); | ||
| this.reader = new LakeSoulArrowReader(reader, 10000); | ||
| } |
There was a problem hiding this comment.
partition value handling can be pushed down to Native
Ceng23333
reviewed
May 11, 2023
| this.conf = null; | ||
| this.awaitTimeout = 10000; | ||
| this.curPartitionId = -1; | ||
| } |
There was a problem hiding this comment.
parameter of LakeSoulPartitionReader should be configurable
…ds && fix no pk table select
Ceng23333
reviewed
May 11, 2023
|
|
||
| @Override | ||
| public void addReader(int subtaskId) { | ||
|
|
YuChangHui
force-pushed
the
cherry-pick/flink_source
branch
from
73887d1
to
6f945e4
Compare
YuChangHui
force-pushed
the
cherry-pick/flink_source
branch
from
4282887
to
c7da8bd
Compare
xuchen-plus
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #194