[NativeIO]panic when target datatype and source datatype mismatch #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zenghua <441651826@qq.com>
Ceng23333
force-pushed
the
bug/native_io_should_panic_at_datatype_mismatch
branch
from
681517b
to
1d4186d
Compare
Signed-off-by: zenghua <441651826@qq.com>
Signed-off-by: zenghua <441651826@qq.com>
xuchen-plus
approved these changes
May 22, 2023
| _ => array.clone(), | ||
| target_datatype => { | ||
| if target_datatype != *array.data_type() { | ||
| panic!("Parquet column cannot be converted in file. Column: [{}], Expected: {}, Found: {}", name, target_datatype, array.data_type()) |
There was a problem hiding this comment.
we should throw the exception to java wrapper, and let spark/flink jobs fail in such unsupported cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.