Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make new files validation go brrrr! #10

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Conversation

spock
Copy link
Contributor

@spock spock commented Dec 22, 2023

closes #7

needs a review and some more testing, I have only tested the following:

  • validating an empty, no-index dataset
  • indexing a fresh dataset without any indices
  • validating a freshly-indexed dataset

@laktak
Copy link
Owner

laktak commented Dec 22, 2023

Thanks for your PR - I'll try to get back to you soon!

@laktak
Copy link
Owner

laktak commented Dec 22, 2023

This looks good, thanks!

@laktak laktak merged commit 360167c into laktak:master Dec 22, 2023
1 check passed
laktak added a commit that referenced this pull request Dec 22, 2023
@laktak
Copy link
Owner

laktak commented Dec 22, 2023

I moved the update parameter so we can keep the version at 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

slower verify in version 3
2 participants