Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The following packages contain code that will be rejected by a future version of Rust #702

Closed
ggssh opened this issue Jan 29, 2023 · 4 comments · Fixed by #717
Closed

The following packages contain code that will be rejected by a future version of Rust #702

ggssh opened this issue Jan 29, 2023 · 4 comments · Fixed by #717
Milestone

Comments

@ggssh
Copy link
Contributor

ggssh commented Jan 29, 2023

When I tried to build my project, I met the following warnings:


The following warnings were discovered during the build. These warnings are an
indication that the packages contain code that will become an error in a
future release of Rust. These warnings typically cover changes to close
soundness problems, unintended or undocumented behavior, or critical problems
that cannot be fixed in a backwards-compatible fashion, and are not expected
to be in wide use.

Each warning should contain a link for more information on what the warning
means and how to resolve it.

To solve this problem, you can try the following approaches:

  • If the issue is not solved by updating the dependencies, a fix has to be
    implemented by those dependencies. You can help with that by notifying the
    maintainers of this problem (e.g. by creating a bug report) or by proposing a
    fix to the maintainers (e.g. by creating a pull request):

  • If waiting for an upstream fix is not an option, you can use the [patch]
    section in Cargo.toml to use your own version of the dependency. For more
    information, see:
    https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html#the-patch-section

The package lalrpop v0.19.8 currently triggers the following future incompatibility lints:

warning: trailing semicolon in macro used in expression position
--> /home/ggssh20/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-7a04d2510079875b/lalrpop-0.19.8/src/normalize/mod.rs:22:11
|
22 | });
| ^
|
::: /home/ggssh20/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-7a04d2510079875b/lalrpop-0.19.8/src/normalize/prevalidate/mod.rs:158:42
|
158 | ... _ => return_err!(
| ____________________________-
159 | | ... annotation.id_span,
160 | | ... r#"cfg annotations must have a feature = "my_feature" argument"# 161 | | ... ), | |_______________________- in this macro invocation | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: for more information, see issue #79813 <https://github.com/rust-lang/rust/issues/79813> = note: #[allow(semicolon_in_expressions_from_macros)]on by default = note: this warning originates in the macroreturn_err` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: trailing semicolon in macro used in expression position
--> /home/ggssh20/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-7a04d2510079875b/lalrpop-0.19.8/src/normalize/mod.rs:22:11
|
22 | });
| ^
|
::: /home/ggssh20/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-7a04d2510079875b/lalrpop-0.19.8/src/normalize/prevalidate/mod.rs:241:40
|
241 | ...=> return_err!(ann_prec.id_span, "invalid argument {} for precedence annotation, expected {}", name, precedence::LVL_AR...
| -------------------------------------------------------------------------------------------------------------------------- in this macro invocation
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #79813 rust-lang/rust#79813
= note: #[allow(semicolon_in_expressions_from_macros)] on by default
= note: this warning originates in the macro return_err (in Nightly builds, run with -Z macro-backtrace for more info)

warning: trailing semicolon in macro used in expression position
--> /home/ggssh20/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-7a04d2510079875b/lalrpop-0.19.8/src/normalize/mod.rs:22:11
|
22 | });
| ^
|
::: /home/ggssh20/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-7a04d2510079875b/lalrpop-0.19.8/src/normalize/prevalidate/mod.rs:242:29
|
242 | ...=> return_err!(ann_prec.id_span, "missing argument for precedence annotation, expected {}", precedence::LVL_AR...
| --------------------------------------------------------------------------------------------------------------- in this macro invocation
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #79813 rust-lang/rust#79813
= note: #[allow(semicolon_in_expressions_from_macros)] on by default
= note: this warning originates in the macro return_err (in Nightly builds, run with -Z macro-backtrace for more info)

warning: trailing semicolon in macro used in expression position
--> /home/ggssh20/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-7a04d2510079875b/lalrpop-0.19.8/src/normalize/mod.rs:22:11
|
22 | });
| ^
|
::: /home/ggssh20/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-7a04d2510079875b/lalrpop-0.19.8/src/normalize/prevalidate/mod.rs:253:40
|
253 | ...=> return_err!(ann_assoc.id_span, "invalid argument {} for associativity annotation, expected {}", name, precedence::SIDE_AR...
| ------------------------------------------------------------------------------------------------------------------------------- in this macro invocation
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #79813 rust-lang/rust#79813
= note: #[allow(semicolon_in_expressions_from_macros)] on by default
= note: this warning originates in the macro return_err (in Nightly builds, run with -Z macro-backtrace for more info)

warning: trailing semicolon in macro used in expression position
--> /home/ggssh20/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-7a04d2510079875b/lalrpop-0.19.8/src/normalize/mod.rs:22:11
|
22 | });
| ^
|
::: /home/ggssh20/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-7a04d2510079875b/lalrpop-0.19.8/src/normalize/prevalidate/mod.rs:254:29
|
254 | ...=> return_err!(ann_assoc.id_span, "missing argument for associativity annotation, expected {}", precedence::SIDE_AR...
| -------------------------------------------------------------------------------------------------------------------- in this macro invocation
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #79813 rust-lang/rust#79813
= note: #[allow(semicolon_in_expressions_from_macros)] on by default
= note: this warning originates in the macro return_err (in Nightly builds, run with -Z macro-backtrace for more info)

warning: trailing semicolon in macro used in expression position
--> /home/ggssh20/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-7a04d2510079875b/lalrpop-0.19.8/src/normalize/mod.rs:22:11
|
22 | });
| ^
|
::: /home/ggssh20/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-7a04d2510079875b/lalrpop-0.19.8/src/normalize/resolve/mod.rs:228:76
|
228 | Def::Nonterminal(0) | Def::Terminal | Def::MacroArg => return_err!(
| _______________________________________________________-
229 | | symbol.span,
230 | | "{} is a {}, not a macro",
231 | | msym.name,
232 | | def.description()
233 | | ),
| |
- in this macro invocation
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #79813 rust-lang/rust#79813
= note: #[allow(semicolon_in_expressions_from_macros)] on by default
= note: this warning originates in the macro return_err (in Nightly builds, run with -Z macro-backtrace for more info)

warning: trailing semicolon in macro used in expression position
--> /home/ggssh20/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-7a04d2510079875b/lalrpop-0.19.8/src/normalize/mod.rs:22:11
|
22 | });
| ^
|
::: /home/ggssh20/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-7a04d2510079875b/lalrpop-0.19.8/src/normalize/resolve/mod.rs:273:36
|
273 | Def::Nonterminal(_) => return_err!(symbol.span, "{} is a macro", id),
| ----------------------------------------------- in this macro invocation
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #79813 rust-lang/rust#79813
= note: #[allow(semicolon_in_expressions_from_macros)] on by default
= note: this warning originates in the macro return_err (in Nightly builds, run with -Z macro-backtrace for more info)

warning: trailing semicolon in macro used in expression position
--> /home/ggssh20/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-7a04d2510079875b/lalrpop-0.19.8/src/normalize/mod.rs:22:11
|
22 | });
| ^
|
::: /home/ggssh20/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-7a04d2510079875b/lalrpop-0.19.8/src/normalize/resolve/mod.rs:281:21
|
281 | None => return_err!(span, "no definition found for {}", id),
| ----------------------------------------------------- in this macro invocation
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #79813 rust-lang/rust#79813
= note: #[allow(semicolon_in_expressions_from_macros)] on by default
= note: this warning originates in the macro return_err (in Nightly builds, run with -Z macro-backtrace for more info)

warning: trailing semicolon in macro used in expression position
--> /home/ggssh20/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-7a04d2510079875b/lalrpop-0.19.8/src/normalize/mod.rs:22:11
|
22 | });
| ^
|
::: /home/ggssh20/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-7a04d2510079875b/lalrpop-0.19.8/src/normalize/macro_expand/mod.rs:167:21
|
167 | None => return_err!(span, "no macro definition found for {}", msym.name),
| ------------------------------------------------------------------ in this macro invocation
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #79813 rust-lang/rust#79813
= note: #[allow(semicolon_in_expressions_from_macros)] on by default
= note: this warning originates in the macro return_err (in Nightly builds, run with -Z macro-backtrace for more info)

warning: trailing semicolon in macro used in expression position
--> /home/ggssh20/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-7a04d2510079875b/lalrpop-0.19.8/src/normalize/mod.rs:22:11
|
22 | });
| ^
|
::: /home/ggssh20/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-7a04d2510079875b/lalrpop-0.19.8/src/normalize/macro_expand/mod.rs:320:25
|
320 | Err(err) => return_err!(span, "invalid regular expression {}: {}", regex, err),
| -------------------------------------------------------------------- in this macro invocation
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #79813 rust-lang/rust#79813
= note: #[allow(semicolon_in_expressions_from_macros)] on by default
= note: this warning originates in the macro return_err (in Nightly builds, run with -Z macro-backtrace for more info)

warning: trailing semicolon in macro used in expression position
--> /home/ggssh20/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-7a04d2510079875b/lalrpop-0.19.8/src/normalize/mod.rs:22:11
|
22 | });
| ^
|
::: /home/ggssh20/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-7a04d2510079875b/lalrpop-0.19.8/src/normalize/macro_expand/mod.rs:398:21
|
398 | / ... return_err!(
399 | | ... span,
400 | | ... "named symbols like {}:{} are only allowed at the top-level of a nonterminal",
401 | | ... ex_id, ex_sym)
| |____________________- in this macro invocation
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #79813 rust-lang/rust#79813
= note: macro invocations at the end of a block are treated as expressions
= note: to ignore the value produced by the macro, add a semicolon after the invocation of return_err
= note: #[allow(semicolon_in_expressions_from_macros)] on by default
= note: this warning originates in the macro return_err (in Nightly builds, run with -Z macro-backtrace for more info)

warning: trailing semicolon in macro used in expression position
--> /home/ggssh20/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-7a04d2510079875b/lalrpop-0.19.8/src/normalize/mod.rs:22:11
|
22 | });
| ^
|
::: /home/ggssh20/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-7a04d2510079875b/lalrpop-0.19.8/src/normalize/token_check/mod.rs:366:13
|
366 | / return_err!(
367 | | spans[literal],
368 | | "{} are not supported in regular expressions",
369 | | feature
370 | | )
| |_____________- in this macro invocation
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #79813 rust-lang/rust#79813
= note: macro invocations at the end of a block are treated as expressions
= note: to ignore the value produced by the macro, add a semicolon after the invocation of return_err
= note: #[allow(semicolon_in_expressions_from_macros)] on by default
= note: this warning originates in the macro return_err (in Nightly builds, run with -Z macro-backtrace for more info)

warning: trailing semicolon in macro used in expression position
--> /home/ggssh20/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-7a04d2510079875b/lalrpop-0.19.8/src/normalize/mod.rs:22:11
|
22 | });
| ^
|
::: /home/ggssh20/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-7a04d2510079875b/lalrpop-0.19.8/src/normalize/token_check/mod.rs:376:13
|
376 | / return_err!(
377 | | spans[literal0],
378 | | "ambiguity detected between the terminal {} and the terminal {}",
379 | | literal0,
380 | | literal1
381 | | )
| |_____________- in this macro invocation
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #79813 rust-lang/rust#79813
= note: macro invocations at the end of a block are treated as expressions
= note: to ignore the value produced by the macro, add a semicolon after the invocation of return_err
= note: #[allow(semicolon_in_expressions_from_macros)] on by default
= note: this warning originates in the macro return_err (in Nightly builds, run with -Z macro-backtrace for more info)

@ggssh ggssh changed the title the following packages contain code that will be rejected by a future version of Rust The following packages contain code that will be rejected by a future version of Rust Jan 29, 2023
@ggssh
Copy link
Contributor Author

ggssh commented Jan 29, 2023

I'm trying my best to correct the source code, but please forgive my limited ability.😭

@andersk
Copy link
Contributor

andersk commented Feb 8, 2023

This is a duplicate of #701, and fixes have been submitted in #660, #676, and #703, but I’m not sure if there are maintainers around anymore to merge them.

@yannham
Copy link
Contributor

yannham commented Mar 22, 2023

Hi, thanks for reporting! The project has gotten a bit more maintenance time again, and we're looking into this specific issue right now. Will fix it in a coming 0.19.9 release very soon.

@yannham yannham added this to the 0.19.9 milestone Mar 24, 2023
@yannham
Copy link
Contributor

yannham commented Mar 24, 2023

Update: this should be fixed on master now, and will be part of the coming 0.19.9 release. Will close this issue then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants