Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lalrpop v0.19.8 contains code that will be rejected by future version of rust #421

Closed
ReeceHumphreys opened this issue Jan 30, 2023 · 4 comments

Comments

@ReeceHumphreys
Copy link
Contributor

ReeceHumphreys commented Jan 30, 2023

When running nightly clippy from the latest toolchain get the following error about lalrpop:

warning: the following packages contain code that will be rejected by a future version of Rust: lalrpop v0.19.8

We should keep an eye on this and update lalrpop if possible.

Edit: Looks like the last time lalrpop was updated was May 5, 2022

@externl
Copy link
Member

externl commented Jan 30, 2023

Does it say what code?

@InsertCreativityHere
Copy link
Member

Does it say what code?

Yeah, it's a semicolon in a macro, and apparently it's no longer legal to put it there.

There's already been 2 issues opened in LALRPOP related to this:
lalrpop/lalrpop#701
lalrpop/lalrpop#702
And a PR that claims to fix this:
lalrpop/lalrpop#703

@InsertCreativityHere
Copy link
Member

I don't think there's anything for us to do about it. There's already a PR open with a fix, and

  1. the warning is only on the nightly clippy
  2. the warning is just that it's deprecated

So even if LALRPOP drags their heels merging the fix, there's plenty of time before this becomes a real issue for us.

@ReeceHumphreys
Copy link
Contributor Author

Looking at the PR seems like a very simple fix. Hopefully its merged in soon! We can close this issue for now and reopen it in the future if it becomes a more pressing matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants