Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a match keyword #30

Merged
merged 3 commits into from
Feb 10, 2016
Merged

Conversation

Nemo157
Copy link
Contributor

@Nemo157 Nemo157 commented Feb 1, 2016

No description provided.

@Nemo157
Copy link
Contributor Author

Nemo157 commented Feb 1, 2016

I'm pretty sure that this will not cover every single case yet, and the error messages aren't the greatest (missing ,'s normally cause a flow on error instead of highlighting the exact issue, at least the errors are generally around the right place though).

But, it does support more stuff than what is tested 😄. Even using it inside attributes works fine (I'll add a test for that).

@Nemo157
Copy link
Contributor Author

Nemo157 commented Feb 9, 2016

Rebased onto latest master.

self.shift(1);
match_var.push(tt.clone());
},
[] => parse_error!(self, sp, "expected body for this #match"),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should say @match

lambda-fairy added a commit that referenced this pull request Feb 10, 2016
Add support for a match keyword
@lambda-fairy lambda-fairy merged commit b738d9d into lambda-fairy:master Feb 10, 2016
@lambda-fairy
Copy link
Owner

LGTM, thanks!

@Nemo157 Nemo157 deleted the match branch March 8, 2016 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants