Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix logic for android #7

Merged
merged 2 commits into from
Jan 5, 2021
Merged

fix logic for android #7

merged 2 commits into from
Jan 5, 2021

Conversation

rossy0213
Copy link
Member

@rossy0213 rossy0213 commented Jan 3, 2021 •
edited
Loading

なに

  1. android chromeで自動停止を挽回するロジック追加した。
    2. 停止ボタンを追加した。
  2. 録音中の文字表示ロジックを修正した。

なぜ

  1. Android Chromeで音声認識がすぐに停止する #3
    2. 音声認識の停止ボタンを追加する #4
  2. 録音確定後の文字がクリアされない問題があった。

close #3
close # 4

@vercel
Copy link

vercel bot commented Jan 3, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/yoidea/bragging-detector/ohu4ryi9p
✅ Preview: https://bragging-detector-git-add-stop-button.yoidea.vercel.app

@rossy0213 rossy0213 requested a review from yoidea January 3, 2021 17:47
@rossy0213
Copy link
Member Author

rossy0213 commented Jan 3, 2021 •
edited
Loading

stop()メソッドとonendイベント発火のタイミング不明すぎ...
自分のJS力が問題なのか？仕様っぽい。

@rossy0213 rossy0213 changed the title add stop button and fix logic fix logic Jan 5, 2021
fix: delete no need code :neckbeard:
af17af4 
add: tricky logic for android chrome :neckbeard:

test: just test :neckbeard:

test: just test :neckbeard:

test: just test :neckbeard:

test: just test :neckbeard:

test: just test :neckbeard:

test: just test :neckbeard:

test: just test :neckbeard:

test: just test :neckbeard:

test: just test :neckbeard:

test: just test :neckbeard:

test: just test :neckbeard:

test: just test :neckbeard:

test: just test :neckbeard:

test: just test :neckbeard:

test: just test :neckbeard:

test: just test :neckbeard:

test: just test :neckbeard:

test: just test :neckbeard:

test: just test :neckbeard:

test: just test :neckbeard:

delete: stop button :neckbeard:

fix: button format:neckbeard:

fix: onend function :neckbeard:

fix: logic :neckbeard:

fix: logic :neckbeard:

fix: logic :neckbeard:

fix: logic :neckbeard:

fix: format :neckbeard:

fix: logic :neckbeard:

fix: logic :neckbeard:

fix: logic :neckbeard:

fix: logic :neckbeard:

fix: logic :neckbeard:

fix: format :neckbeard:
@rossy0213 rossy0213 changed the title fix logic fix logic fgp Jan 5, 2021
@rossy0213 rossy0213 changed the title fix logic fgp fix logic for android Jan 5, 2021
yoidea
yoidea approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@yoidea yoidea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rossy0213 rossy0213 merged commit 97eafbf into master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoidea yoidea yoidea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Android Chromeで音声認識がすぐに停止する
2 participants
@rossy0213 @yoidea