Restructure SMILES lookup services into chain of responsibility #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were only using the service at
https://cactus.nci.nih.gov/chemical/structurefor SMILES lookups from compound names. This works pretty well, but sometimes we get SMILES back that contains vertical pipe|characters which breaks Sourire and won't render. These mainly seem to appear in organometallic compounds (ligand-related?) and just don't play nice with the renderer.To remedy this, we now fall back to attempting to scrape the SMILES from the compound's Wikipedia page. This means it was necessary to restructure SMILES lookup services to support the chain of responsibility pattern.