Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hints QUAD_BIT & DI_BIT panick if ids. m = 1 #1179

Closed
fmoletta opened this issue May 24, 2023 · 0 comments · Fixed by #1185
Closed

Hints QUAD_BIT & DI_BIT panick if ids. m = 1 #1179

fmoletta opened this issue May 24, 2023 · 0 comments · Fixed by #1185
Labels
bug Something isn't working hints Hint implementations

Comments

@fmoletta
Copy link
Member

There is an unchecked m - 1 which causes the vm to panick with substraction underflow
@fmoletta fmoletta added the bug Something isn't working label May 24, 2023
@fmoletta fmoletta changed the title Hint QUAD_BIT panicks if ids. m = 1 Hint QUAD_BIT panicks if ids. m = 1 May 24, 2023
@fmoletta fmoletta added the hints Hint implementations label May 24, 2023
@fmoletta fmoletta changed the title Hint QUAD_BIT panicks if ids. m = 1 Hints QUAD_BIT & DI_BIT panick if ids. m = 1 May 29, 2023
@fmoletta fmoletta linked a pull request May 29, 2023 that will close this issue
Catch possible subtraction error in QUAD_BIT & DI_BIT hints #1185
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working hints Hint implementations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Catch possible subtraction error in QUAD_BIT & DI_BIT hints lambdaclass/cairo-vm
1 participant
@fmoletta