Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cairo-vm v0.1.1 breaks starkware's cairo-lang-casm v0.1.0 crate #730

Closed
CHr15F0x opened this issue Jan 16, 2023 · 1 comment
Closed

cairo-vm v0.1.1 breaks starkware's cairo-lang-casm v0.1.0 crate #730

CHr15F0x opened this issue Jan 16, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@CHr15F0x
Copy link

Describe the bug
When using cairo-lang-starknet as a dependency in your own Rust crate it turns out that cairo-lang-casm does not build.
The problem stems from the fact that cairo-* crates depend at a workspace level on

cairo-vm = "0.1.0"

which means that all cairo-vm versions from the range >= 0.1.0 && <0.2.0 are valid here.
Unfortunately cairo-vm version 0.1.1 introduces breaking changes and thus cairo-lang-starknet (among others) fails to build.

To Reproduce
Steps to reproduce the behavior:

cargo new --lib example
cd example/
cargo add cairo-lang-starknet
cargo check 

Cargo check fails.

Expected behavior
Cargo check passes.

Additional context
I imagine that cairo-vm 0.1.1 could be for yanked and re-released as 0.2.0 on crates.io which would fix all depending crates that use the cairo-vm = "0.1.0" dependency.
Right now I am using a fork of cairo which forces "=0.1.0" for cairo-vm.

@Juan-M-V
Copy link
Contributor

Juan-M-V commented Jan 18, 2023

Hi @CHr15F0x, we are working on a better fix for this issue. For now your approach seems like the best option. We are going to update the README to include this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants