Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ease Riak Setup and usage #5

Closed
3 of 4 tasks
fkrause98 opened this issue Jun 21, 2022 · 0 comments
Closed
3 of 4 tasks

Ease Riak Setup and usage #5

fkrause98 opened this issue Jun 21, 2022 · 0 comments

Comments

@fkrause98
Copy link
Collaborator

fkrause98 commented Jun 21, 2022

There are some things that we can do better and that would be good to address as we're planning to provide
an elixir library for riak, like:

  • Avoiding weird Erlang macros like this one:
handle_handoff_command(?FOLD_REQ{foldfun=FoldFun, acc0=Acc0}, _Sender,
                       State = #{data := Data}) ->
  log("Received fold request for handoff", State),
  Result = maps:fold(FoldFun, Acc0, Data),
  {reply, Result, State};

Currently I'm using this as a workaround:

  require Record

  Record.defrecord(
    :fold_req_v2,
    :riak_core_fold_req_v2,
    Record.extract(:riak_core_fold_req_v2, from_lib: "riak_core/include/riak_core_vnode.hrl")
  )
  • See If we can make the VMaster setup more straight forward.
  • See If we can make the FSM Coverage setup more straight forward.
  • Maybe provide an Elixir specific VNode behaviour that wraps the original one.
@fkrause98 fkrause98 mentioned this issue Jul 7, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant