Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont send all reminders at once #34

Open
facundoolano opened this issue Jul 4, 2017 · 0 comments
Open

dont send all reminders at once #34

facundoolano opened this issue Jul 4, 2017 · 0 comments
Milestone

Comments

@facundoolano
Copy link
Contributor

facundoolano commented Jul 4, 2017

To avoid potential throttling issues with the external services.

For example, if N users for the same country configure a slack channel, it's probable (if they use the same default reminder time) that when the holiday comes, we'll be making a burst of N requests to slack at almost the same time. This will probably cause slack to reject the requests. The same could happen with most services.

Since there's no special reason to process all the reminders at the same instant (and there's usually several minutes until the next checker run), we could queue/break the reminders in batches and send them with delays.

@unbalancedparentheses unbalancedparentheses modified the milestone: backlog Jul 13, 2017
@facundoolano facundoolano changed the title dont send all notifictions for all users at once dont send all notifications for all users at once Jul 14, 2017
@facundoolano facundoolano changed the title dont send all notifications for all users at once dont send all reminders at once Nov 9, 2017
@facundoolano facundoolano modified the milestones: backlog, 0.3 Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants