Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Rename types.ex to base.ex #632

Open
Arkenan opened this issue Jan 15, 2024 · 7 comments
Open

[Refactor] Rename types.ex to base.ex #632

Arkenan opened this issue Jan 15, 2024 · 7 comments
Assignees
@mahmudsudo
Labels
good first issue Good for newcomers refactor Ideas to improve code usability or performance with little or no change to behavior

Comments

@Arkenan
Copy link
Collaborator

Arkenan commented Jan 15, 2024 •
edited by MegaRedHand

We have a file for base types. We should:

  1. Rename the file from types.ex to base.ex
  2. Rename the module from Types to LambdaEthereumConsensus.Types.Base.
  3. Use aliases in files where it's used.
@MegaRedHand MegaRedHand added the good first issue Good for newcomers label Jan 15, 2024
@mabsattar
Copy link

mabsattar commented Jan 28, 2024 •
edited

Hi can you assign me, I'd like to tackle this!

@mpaulucci mpaulucci added the refactor Ideas to improve code usability or performance with little or no change to behavior label Jan 29, 2024
@MegaRedHand
Copy link
Collaborator

Hey @mabsattar! Sorry for the late response. I've assigned the task to you. Please ping me if you have any questions!

@mabsattar
Copy link

@MegaRedHand sure, thanks for assigning me.

@mpaulucci
Copy link
Collaborator

Hi @mabsattar, any updates on this?

@MegaRedHand MegaRedHand changed the title [Refactor] Rename mod.ex to base.ex [Refactor] Rename types.ex to base.ex Apr 27, 2024
@mabsattar
Copy link

Hi @mabsattar, any updates on this?

hi, nope i'm not working on it at the moment.

@mahmudsudo
Copy link

can i take on this ?

@Arkenan
Copy link
Collaborator Author

Arkenan commented Jun 6, 2024

You can take it @mahmudsudo !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mahmudsudo mahmudsudo

Labels
good first issue Good for newcomers refactor Ideas to improve code usability or performance with little or no change to behavior
Projects
Lambda Ethereum Consensus Node
Status: In progress
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mpaulucci @Arkenan @MegaRedHand @mahmudsudo @mabsattar