feat(elliptic curve): add fuzzer for BLS12-381 #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MauroToscano
requested changes
Nov 6, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #664 +/- ##
=======================================
Coverage 96.17% 96.17%
=======================================
Files 132 132
Lines 29847 29847
=======================================
Hits 28704 28704
Misses 1143 1143 ☔ View full report in Codecov by Sentry. |
PatStiles
changed the title
diegokingston
approved these changes
Nov 7, 2023
MauroToscano
approved these changes
Nov 7, 2023
MauroToscano
approved these changes
Nov 7, 2023
PatStiles
force-pushed
the
feat/bls12_381_fuzz
branch
from
c505625
to
2117d26
Compare
schouhy
suggested changes
Nov 22, 2023
| // -O = O | ||
| assert_eq!(g1_zero.neg(), g1_zero, "Neutral mul element a failed"); | ||
|
|
||
| // P * O = O |
There was a problem hiding this comment.
It's very uncommon to use multiplicative notation for elliptic curve operations. Please use + here and in every other comment.
There was a problem hiding this comment.
Addressed thanks for the feedback!
PatStiles
force-pushed
the
feat/bls12_381_fuzz
branch
from
8590b2f
to
7fac432
Compare
entropidelic
approved these changes
Nov 23, 2023
schouhy
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Fuzzer for BLS12-381
Description
Adds a differential fuzzer for BLS12-381 for elliptic curve operations.
Type of change
Please delete options that are not relevant.
Checklist