New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pallas and Vesta fields #690
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the custom serializer if possible. The one in the Starknet field existed because of a very specific requirement of the the standarized fields of Starknet, and making them work with no std. You don't even need it for wasm.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #690 +/- ##
==========================================
- Coverage 96.16% 96.16% -0.01%
==========================================
Files 132 134 +2
Lines 29904 29906 +2
==========================================
Hits 28758 28758
- Misses 1146 1148 +2 ☔ View full report in Codecov by Sentry. |
Add Pallas and Vesta fields
Description
This PR add the Pallas and Vesta base fields in order to later construct the Pasta curves. There is no issue associated to this PR, but it was requested in Lambdaworks.
Type of change