Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pallas and Vesta fields #690

Merged
merged 10 commits into from Dec 6, 2023
Merged

Conversation

mdvillagra
Copy link
Contributor

@mdvillagra mdvillagra commented Nov 21, 2023

Add Pallas and Vesta fields

Description

This PR add the Pallas and Vesta base fields in order to later construct the Pasta curves. There is no issue associated to this PR, but it was requested in Lambdaworks.

Type of change

  • New feature

@mdvillagra mdvillagra marked this pull request as ready for review November 21, 2023 13:40
@mdvillagra mdvillagra requested review from schouhy, ajgara and a team as code owners November 21, 2023 13:40
Copy link
Collaborator

@MauroToscano MauroToscano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the custom serializer if possible. The one in the Starknet field existed because of a very specific requirement of the the standarized fields of Starknet, and making them work with no std. You don't even need it for wasm.

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0f3b5ef) 96.16% compared to head (f60f27e) 96.16%.

Files Patch % Lines
math/src/field/fields/pallas_field.rs 0.00% 1 Missing ⚠️
math/src/field/fields/vesta_field.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #690      +/-   ##
==========================================
- Coverage   96.16%   96.16%   -0.01%     
==========================================
  Files         132      134       +2     
  Lines       29904    29906       +2     
==========================================
  Hits        28758    28758              
- Misses       1146     1148       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdvillagra mdvillagra changed the title Add Pallas field Add Pallas and Vesta fields Nov 23, 2023
@entropidelic entropidelic added this pull request to the merge queue Dec 6, 2023
Merged via the queue into lambdaclass:main with commit b9b3118 Dec 6, 2023
7 checks passed
@mdvillagra mdvillagra deleted the pallas-field branch December 6, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants