Optimize prover boundary evaluations in construction of composition polynomial #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we have some benchmark results? |
Oppen
reviewed
Jun 5, 2023
src/air/constraints/evaluator.rs
Outdated
Comment on lines
90
to
114
| let mut boundary_polys_evaluations = Vec::with_capacity(boundary_polys.len()); | ||
| for poly in boundary_polys.iter() { | ||
| let evaluations = evaluate_polynomial_on_lde_domain( | ||
| poly, | ||
| domain.blowup_factor, | ||
| domain.interpolation_domain_size, | ||
| &domain.coset_offset, | ||
| ) | ||
| .unwrap(); | ||
| boundary_polys_evaluations.push(evaluations); | ||
| } | ||
|
|
||
| let mut boundary_zerofiers_inverse_evaluations = | ||
| Vec::with_capacity(boundary_zerofiers.len()); | ||
| for poly in boundary_zerofiers.iter() { | ||
| let mut evaluations = evaluate_polynomial_on_lde_domain( | ||
| poly, | ||
| domain.blowup_factor, | ||
| domain.interpolation_domain_size, | ||
| &domain.coset_offset, | ||
| ) | ||
| .unwrap(); | ||
| FieldElement::inplace_batch_inverse(&mut evaluations); | ||
| boundary_zerofiers_inverse_evaluations.push(evaluations); | ||
| } |
There was a problem hiding this comment.
We can evaluate the polynomials before collecting the original vectors, so we halve the memory taken by the whole operation.
diegokingston
approved these changes
Jun 5, 2023
Codecov Report
@@ Coverage Diff @@
## main #22 +/- ##
==========================================
+ Coverage 97.92% 97.93% +0.01%
==========================================
Files 33 33
Lines 4872 4902 +30
==========================================
+ Hits 4771 4801 +30
Misses 101 101
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Good results |
MauroToscano
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves 2 times the prover speed.