Trace to Prover Refactor #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oppen
reviewed
Jun 5, 2023
tests/integration_tests.rs
Outdated
| program.push(memory.get(&i).unwrap().clone()); | ||
| } | ||
| // This should be auto calculated | ||
| let padded_trace_length = next_power_of_two(memory.len() as u64) as usize; |
There was a problem hiding this comment.
The stdlib already gives us a method to find the next power of 2;
Suggested change
| let padded_trace_length = next_power_of_two(memory.len() as u64) as usize; | |
| let padded_trace_length = memory.len().next_power_of_two(); |
Oppen
reviewed
Jun 5, 2023
src/cairo_run/run.rs
Outdated
| /// Uses [cairo-rs](https://github.com/lambdaclass/cairo-rs/) project to run the program. | ||
| /// | ||
| /// # Params | ||
| /// | ||
| /// `entrypoint_function` - the name of the entrypoint function tu run. If `None` is provided, the default value is `main`. | ||
| /// `layout` - type of layout of Cairo. | ||
| /// `layout` - type of layout of Cairo. `` |
There was a problem hiding this comment.
The trailing quotes look strange here.
Codecov Report
@@ Coverage Diff @@
## main #23 +/- ##
==========================================
- Coverage 98.48% 97.92% -0.56%
==========================================
Files 31 33 +2
Lines 4818 4872 +54
==========================================
+ Hits 4745 4771 +26
- Misses 73 101 +28
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
entropidelic
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need another refactor, and after optimization make a bigger test suite to be run in the CI