New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commit multiple columns using a single Merkle Tree #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
building merkle trees
Codecov Report
@@ Coverage Diff @@
## main #47 +/- ##
==========================================
+ Coverage 97.84% 98.02% +0.18%
==========================================
Files 33 33
Lines 4956 5075 +119
==========================================
+ Hits 4849 4975 +126
+ Misses 107 100 -7
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
MauroToscano
approved these changes
Jun 13, 2023
ajgara
approved these changes
Jun 13, 2023
entropidelic
approved these changes
Jun 13, 2023
feltroidprime
pushed a commit
to feltroidprime/lambdaworks_cairo_prover
that referenced
this pull request
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following:
There are two merkle trees for each part of the RAP because the prover needs to commit to the first ones before getting the RAP challenges from the verifier. Improvements on this are left for another PR.