Improve performance on "big" files #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 20, 2019 13:40
Closed
|
Just tried this and it's now really fast ... about 20 - 25x faster on one sample file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is focused on improving performance when loading "big" files.
I used Apple's Instruments.app to tell me where we were wasting CPU time. With no changes we had a graph like this :
"Spinning" means that the GUI is frozen, in reference to macOS's beach ball icon spinning when the application is unresponsive
Looking at the profiler output, we can see that most of the time was spent in USBModel::updateNodes().
By making fewer calls to this method, I did shave a few seconds off:
By looking at the profiler output even closer, I noticed that we spent too much time in QAbstractItemModel's endInsertRows() method. I decided to make fewer calls to endInsertRows and beginInsertRows() (they go in pairs). That improved a lot the loading times!
All my tests were performed on this file:
ft4232trace.usb.zip