Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

round-trip error with ###NaN #11

Open
plexus opened this issue Apr 11, 2019 · 4 comments
Open

round-trip error with ###NaN #11

plexus opened this issue Apr 11, 2019 · 4 comments
Labels
bug Something isn't working documentation

Comments

@plexus
Copy link
Member

plexus commented Apr 11, 2019

https://circleci.com/gh/lambdaisland/deep-diff/65?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

Something the generative tests caught, not sure this is a big issue but something to look into.

@oxalorg oxalorg added the bug Something isn't working label Nov 18, 2020
@alysbrooks
Copy link
Member

I think there are two issues, and I think they're really two manifestations with the same issue. (not= ##NaN ##NaN) which breaks diff, but it also breaks our tests.

matchers-combinators and clojure.data/diff fail (if that's the right word) in the same way. Maybe this just needs to be documented?

@alysbrooks
Copy link
Member

Glad I put my research into writing, but I don't think this should be a priority for the moment.

@plexus
Copy link
Member Author

plexus commented Nov 14, 2022

Seems that CircleCI link no longer works for me... should've taken a screenshot.

Adding a section to the README with "known limitations" would perhaps be the best short-term action here.

@alysbrooks
Copy link
Member

I think this makes sense to leave something open as a documentation fix. Fixing the underlying problem probably won't be a priority, so this can be closed as "PR welcome" once the documentation is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation
Projects
Status: 🙈Out of Scope
Development

No branches or pull requests

3 participants