[WIP] Redesign v3 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature of tailwind is amazing!!!! @plexus @barrosfelipe @GaiwanTeam
Adds the logo as an SVG asset
A few stylistic considerations: - Wrap word *consultancy*. - Reword to avoid starting two phrases with *We* and to invite after the visitor knows what we do (personal preference but I feel this is elegant). - Avoid overusing ampersands (the main heading already includes a big one). - Decrease paragraph length to improve legibility. - Acronyms don’t go well with apostrophes. - 3rd-party or third-party (with an hyphen) when used as an adjective. - Make sure *3rd-party integrations* don’t wrap.
The hyphen between spaces doesn’t look good here and isn’t recommended by typographers in this situation. In my opinion, the location data should be displayed elsewhere (not right after the name and with the same typographical value) but, sticking to this implementation, both the en dash and the parenthesis are better options. The en dash though, in this typeface and weight combination, looks a bit weird and would require some special space characters to look relatively okay. After looking at both I believe the parentheses looks better, don‘t require special characters and fit the semantic purpose of providing additional information.
The curly quote mark looks better when it is applied outside the "paragraph box", both when it is used like this, only for style, as when it just happens to appear in the beginning of a line.
|
@oxalorg added some minor stuff directly here, hope you don't mind. Feel free to ditch stuff you dislike. Tried not to modify your layout, but only to add small enhancements. |
|
Amazing changes! The Gaiwan logo update looks soooooo much better now 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gaiwan v3 redesign!
I'm adding a bit of css tooling via npm to setup tailwind. Although tailwind does not work with hiccup, I'm making postcss look at our rendered static site and using tailwind on that output. This way we can use pure tailwind and everything works without any hiccup / clj file specific workarounds.
The rest of our static site generation logic remains the same.