Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the skip-add-classpath? flag #196

Merged
merged 1 commit into from Mar 8, 2021
Merged

Document the skip-add-classpath? flag #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 5 additions & 3 deletions doc/03_configuration.md
View file
Open in desktop
Expand Up @@ -155,11 +155,13 @@ duplicated between `tests.edn` and your project configuration (`deps.edn`,
However, often people will have these paths in their `deps.edn` anyway (e.g. in
a `:test` or `:dev` profile), so they are accessible for interactive evaluation
(REPL, in-buffer eval). In some cases you also do not *want* Kaocha to add
these, because the way we make sure we have a dynamic classloader so we can add
entries at runtime can confuse third party tools.
these, because it can confuse third-party tools. This is because Kaocha needs a
`DynamicClassLoader` to be able to add classpath entries at runtime. If the
current classloader is not a `DynamicClassLoader` then we set one up ourselves,
but there have been cases where this caused issues with other tools.

In these cases you can add `:kaocha.testable/skip-add-classpath? false` to the
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, I was wondering if we want :kaocha.testable/skip-add-classpath? true instead here cause that would actually skip the add-classpath statement in the code?

If not apologies, maybe I am not understanding too much the use case in the README...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh yes I believe you're right

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok no worries I can open a PR if that's the case.

test suite definition, to disable this behavior.
test suite definition to disable this behavior.

### :kaocha.type/clojure.test

Expand Down