Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Add summary reporter #304

Closed

Conversation

NoahTheDuke
Copy link
Contributor

Hey friends,

I'm interested in a reporter that does not print anything except for the summary at the end. I would ideally also like a leading "Starting test run" so I know it's working, but there doesn't seem to be support for that at the moment, so I don't mind excluding that.

This is pretty simple and I don't want to put a ton of work into it if there's no interest so here's the minimum working example. If there is tho, I'll write up all of the docs and changelog necessary. I couldn't find where the reporter symbols (the vectors) are tested, which is why I didn't write any tests for this PR.

Thanks so much!

@plexus
Copy link
Member

plexus commented Aug 9, 2022

You're looking for kaocha.report/result

@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #304 (3d7b362) into main (f97d9fd) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
+ Coverage   75.53%   75.55%   +0.01%     
==========================================
  Files          51       51              
  Lines        2714     2716       +2     
  Branches      252      252              
==========================================
+ Hits         2050     2052       +2     
  Misses        506      506              
  Partials      158      158              
Flag Coverage Δ
integration 57.06% <100.00%> (+0.03%) ⬆️
unit 69.55% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/kaocha/report.clj 84.86% <100.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@NoahTheDuke
Copy link
Contributor Author

You're looking for kaocha.report/result

I don't see it referenced anywhere in the docs. Would you accept a PR mentioning it?

@plexus
Copy link
Member

plexus commented Aug 10, 2022

Yeah sure, that would be great. It's mostly used as part of other reporters, I guess I never imagined people using it by itself but it makes sense.

@alysbrooks
Copy link
Member

@NoahTheDuke I think I'll close this PR so you can open a separate one with the do change. Or are you planning to repurpose this PR?

@NoahTheDuke
Copy link
Contributor Author

Sorry, been busy at work. I'll open a new PR with the documentation.

@NoahTheDuke NoahTheDuke deleted the nb/summary-reporter branch October 21, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants