Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect disabling of unload/reload when watching #424

Conversation

simon-katz
Copy link
Contributor

@simon-katz simon-katz commented Aug 29, 2023

DRAFT: Awaiting lambdaisland.tools.namespace.repl/remove-disabled to be made public — the subject of another PR (lambdaisland/tools.namespace#5).

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 31.03% and project coverage change: +0.01% 🎉

Comparison is base (d390b8e) 75.08% compared to head (98c2200) 75.10%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
+ Coverage   75.08%   75.10%   +0.01%     
==========================================
  Files          52       52              
  Lines        2802     2804       +2     
  Branches      289      289              
==========================================
+ Hits         2104     2106       +2     
  Misses        511      511              
  Partials      187      187              
Flag Coverage Δ
integration 56.24% <0.00%> (-0.08%) ⬇️
unit 69.43% <31.03%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/kaocha/watch.clj 71.79% <31.03%> (+0.24%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

plexus added a commit to lambdaisland/tools.namespace that referenced this pull request Aug 30, 2023
## Added

- Make `remove-disabled` public. This is needed by [lambdaisland/kaocha#424](lambdaisland/kaocha#424).

## Fixed

## Changed
@plexus plexus merged commit 2b9b421 into lambdaisland:main Aug 30, 2023
6 of 7 checks passed
@simon-katz simon-katz deleted the respect-disabling-of-unload-reload-when-watching branch August 30, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants