You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 8, 2024. It is now read-only.
When user close a gina-commit buffer with :wq, the commit message will be committed without prompt
When user close a gina-commit buffer with :q, a prompt will be appeared then
When user hit <Enter> or type Y(es), the commit message will be committed
When user type N(o), the commit message will NOT be committed and the message will be cached so that if user re-open a gina-commit buffer, the cached message is used as a default message
However, as @bimlas mentioned in #44, gina.vim currently get a cached commit message by
Perform an actual commit with cached message
Get a cleaned up commit message
Reset a previous commit
Remove reflogs for above operations
To get a correct cleaned up commit message.
As you notice, this is a bit hackie code and may have some problems. Additionally I noticed that the priority of caching is not really high and I seldom use this feature.
So now I'm thinking about dropping this cache mechanisms to simplify as like #44.
Once I simplify as #44 (or simply merge #44), the behavior would become
When user close a gina-commit buffer with :wq, the commit message will be committed without prompt
When user close a gina-commit buffer with :q, a prompt will be appeared then
When user hit <Enter> or type Y(es), the commit message will be committed
When user type N(o), the commit message will NOT be committed and the message will be discarded and when user re-open a gina-commit buffer, an empty commit message will be used (This is a different behavior)
While this change a behavior, I would like to hear your opinions before I did. This behavior should be settled before the first production release (better to settle before the third beta release).
Currently, the behavior of
:Gina commit
isgina-commit
buffer with:wq
, the commit message will be committed without promptgina-commit
buffer with:q
, a prompt will be appeared then<Enter>
or typeY(es)
, the commit message will be committedN(o)
, the commit message will NOT be committed and the message will be cached so that if user re-open agina-commit
buffer, the cached message is used as a default messageHowever, as @bimlas mentioned in #44, gina.vim currently get a cached commit message by
To get a correct cleaned up commit message.
As you notice, this is a bit hackie code and may have some problems. Additionally I noticed that the priority of caching is not really high and I seldom use this feature.
So now I'm thinking about dropping this cache mechanisms to simplify as like #44.
Once I simplify as #44 (or simply merge #44), the behavior would become
gina-commit
buffer with:wq
, the commit message will be committed without promptgina-commit
buffer with:q
, a prompt will be appeared then<Enter>
or typeY(es)
, the commit message will be committedN(o)
, the commit message will NOT be committed and the message will be discarded and when user re-open agina-commit
buffer, an empty commit message will be used (This is a different behavior)While this change a behavior, I would like to hear your opinions before I did. This behavior should be settled before the first production release (better to settle before the third beta release).
It related to #59 a bit as well.
The text was updated successfully, but these errors were encountered: