Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Oauth parsing structure changes #122

Closed
1 task done
VikrantKS opened this issue Apr 5, 2022 · 1 comment
Closed
1 task done

[Bug]: Oauth parsing structure changes #122

VikrantKS opened this issue Apr 5, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@VikrantKS
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What is the current behavior?

Currently synapse write the OAuth in the format
{"data": {"access_token": "", "expiry": "", "refresh_token": "", "token_type": ""}}

But nucleus reads OAuth in the following format
{"access_token": "", "expiry": "", "refresh_token": "", "token_type": ""}

What is the expected behavior?

The read and write structure of OAuth should be consistent for proper functioning of synapse
Synapse write structure should be
{"access_token": "", "expiry": "", "refresh_token": "", "token_type": ""}

Steps To Reproduce

  1. Connect synapse
  2. Run a job (via adding commit)
  3. The job will fail

Version

Test-at-scale Community Edition

@VikrantKS VikrantKS added the bug Something isn't working label Apr 5, 2022
@Shivanshu-lambdatest
Copy link

@VikrantKS @rishabh-arya95 Please close this issue If resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants