(dsl): Support matchBooleanPrefix query
#304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbulaja98
requested changes
Aug 21, 2023
| @@ -0,0 +1,26 @@ | |||
| --- | |||
There was a problem hiding this comment.
Please show using of miniumum_should_match parameter in doc.
| @@ -415,6 +415,44 @@ object ElasticQuery { | |||
| final def matches[A: ElasticPrimitive](field: String, value: A): MatchQuery[Any] = | |||
| Match(field = field, value = value) | |||
|
|
|||
| /** | |||
| * Constructs a type-safe instance of [[zio.elasticsearch.query.MatchBooleanPrefixQuery]] using the specified | |||
| * parameters. [[zio.elasticsearch.query.MatchBooleanPrefixQuery]] analyzes its input and constructs a `bool` query | |||
There was a problem hiding this comment.
Make bool query a reference.
| * @tparam S | ||
| * document for which field query is executed | ||
| * @tparam A | ||
| * the type of value to be matched. A JSON decoder must be in scope for this type |
There was a problem hiding this comment.
Suggested change
| * the type of value to be matched. A JSON decoder must be in scope for this type | |
| * the type of value to be matched. A JSON decoder must be provided in the scope for this type |
|
|
||
| /** | ||
| * Constructs an instance of [[zio.elasticsearch.query.MatchBooleanPrefixQuery]] using the specified parameters. | ||
| * [[zio.elasticsearch.query.MatchBooleanPrefixQuery]] analyzes its input and constructs a `bool` query from the |
| * the field for which query is specified for | ||
| * @param value | ||
| * the value to be matched, represented by an instance of type `A` | ||
| * @tparam A |
Comment on lines
576
to
577
| ) extends MatchBooleanPrefixQuery[S] { self => | ||
| def minimumShouldMatch(value: Int): MatchBooleanPrefixQuery[S] = |
There was a problem hiding this comment.
Put an empty line between.
| @@ -873,6 +873,53 @@ object ElasticQuerySpec extends ZIOSpecDefault { | |||
| equalTo(Match[TestDocument, Double](field = "doubleField", value = 3.14)) | |||
| ) | |||
| }, | |||
| test("matchBooleanPrefix") { | |||
There was a problem hiding this comment.
Add one test for query with suffix (for creating json too).
| @@ -917,6 +917,48 @@ object HttpExecutorSpec extends IntegrationSpec { | |||
| Executor.execute(ElasticRequest.createIndex(firstSearchIndex)), | |||
| Executor.execute(ElasticRequest.deleteIndex(firstSearchIndex)).orDie | |||
| ), | |||
| test("search for a document using a match boolean prefix query") { | |||
There was a problem hiding this comment.
Write just one it-test for this query. There is no need to check minimumShouldMatch only.
drmarjanovic
requested changes
Aug 22, 2023
| ``` | ||
|
|
||
| You can find more information about `MatchBooleanPrefix` query [here](https://www.elastic.co/guide/en/elasticsearch/reference/7.17/query-dsl-match-bool-prefix-query.html). | ||
|
|
There was a problem hiding this comment.
Unnecessary new line.
| @@ -873,6 +873,57 @@ object ElasticQuerySpec extends ZIOSpecDefault { | |||
| equalTo(Match[TestDocument, Double](field = "doubleField", value = 3.14)) | |||
| ) | |||
| }, | |||
| test("matchBooleanPrefix") { | |||
There was a problem hiding this comment.
Move this between matchAll and matches.
| @@ -2427,6 +2478,76 @@ object ElasticQuerySpec extends ZIOSpecDefault { | |||
| assert(queryTsInt.toJson(fieldPath = None))(equalTo(expectedTsInt.toJson)) && | |||
| assert(queryTsString.toJson(fieldPath = None))(equalTo(expectedTsString.toJson)) | |||
| }, | |||
| test("matchBooleanPrefix") { | |||
There was a problem hiding this comment.
Move this between matchAll and matches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #91