Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laminas\ApiTools\Doctrine\ORM\QueryBuilder #6

Closed
wants to merge 29 commits into from

Conversation

TomHAnderson
Copy link
Contributor

@TomHAnderson TomHAnderson commented Feb 6, 2020

Q A
Documentation yes
Bugfix no
BC Break yes
New Feature no
RFC no
QA no

Remove ODM and split this repository into ODM and ORM and remove all Apigility tooling #2

This module goal was to support "Doctrine" which means both ORM and ODM. But combining these unrelated technologies has proven difficult. I am proposing this PR be the start of a new repository

api-tools-doctrine-querybuilder-orm

The same approach will be taken for ODM where all ORM will be removed and it will become

api-tools-doctrine-querybuilder-odm

@TomHAnderson
Copy link
Contributor Author

This can't be completed until I release a Laminas version of DoctrineORMModule.

@TomHAnderson TomHAnderson changed the title [wip] Removed ODM [wip] Laminas\ApiTools\Doctrine\ORM\QueryBuilder Feb 19, 2020
@TomHAnderson
Copy link
Contributor Author

I'm at an impasse with this PR. The unit tests always pass locally but fail when ran on Travis.

@TomHAnderson TomHAnderson changed the title [wip] Laminas\ApiTools\Doctrine\ORM\QueryBuilder Laminas\ApiTools\Doctrine\ORM\QueryBuilder Mar 2, 2020
@TomHAnderson
Copy link
Contributor Author

This PR is ready to be it's own repository.

@TomHAnderson
Copy link
Contributor Author

phpcs is failing because the license at the top of most files is too long because of the length of this
library's name.

@TomHAnderson
Copy link
Contributor Author

Closing. This work was not signed and there has been no movement on the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant