Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpro/zf-doctrine-hydration-module EOL #15

Closed
TomHAnderson opened this issue Apr 30, 2020 · 9 comments
Closed

phpro/zf-doctrine-hydration-module EOL #15

TomHAnderson opened this issue Apr 30, 2020 · 9 comments

Comments

@TomHAnderson
Copy link
Contributor

Feature Request

Q A
New Feature yes
RFC no
BC Break no

Summary

This repository requires:

"phpro/zf-doctrine-hydration-module": "^2.0.1 || ^3.0 || ^4.1"

I received this email from the owner of that repository today:

Hello @TomHAnderson

We are no longer using Apigility at PHPro anymore.
Therefor, it is hard for me to make the correct decisions for this package.

Feel free to use this package as a base for a new laminas package. Once that one is ready, we can archive this one.

Let me know if there is something I can do to make it easier to hand over the project.

Laminas API Tools could take over maintenance of the package. If Laminas does not want this responsibility I'll gladly move it to API Skeletons.

RSVP

@weierophinney
Copy link
Contributor

Pinging @michalbundyra ...

@michalbundyra
Copy link
Member

@TomHAnderson Thanks for the info. We'd like to include it into Laminas, or move just part of it, what is used by our components. It is not anything urgent right now, as integration works through the bridge library.

Definitely we will be back to this at some point. Thanks.

@javabudd
Copy link

javabudd commented Sep 7, 2020

@michalbundyra Any updates on this? I'd be happy to help if any is needed.

@BacLuc
Copy link

BacLuc commented Mar 14, 2021

+1
this dependency blocks our update of doctrine/doctrine-orm-module.
anything i can do to help?
ecamp/ecamp3#761

BacLuc added a commit to BacLuc/api-tools-doctrine that referenced this issue Mar 14, 2021
…NAMESPACE

Thus remove the dependency to         "laminas/laminas-zendframework-bridge" which is discontinued and makes everybody happy.

Issue: laminas-api-tools#15
@TomHAnderson
Copy link
Contributor Author

Just yesterday I rewrote the Phpro library. I was able to make it work for my needs but I removed the ODM portion. I got rather far in the ODM unit tests but hit a point where I got stuck and, since I haven't seen anyone paying attention to this repository, I just went my own way.

I would be happy to reproduce my work with the caveat that I'll need help with the ODM unit tests. But before that can happen a decision needs to be made about what will become of the Phpro library.

I strongly recommend the Phpro library be brought under the Laminas umbrella so this library does not rely on the external dependency. Once the library exists as part of api-tools I'll submit PRs for the work I can do.

I also rewrote this library yesterday to use the rewritten Phpro library. That was not difficult with just some changes for Doctrine persistence.

https://github.com/API-Skeletons/doctrine-orm-hydration-module
https://github.com/API-Skeletons/api-tools-doctrine

To be honest my expectations of anything changing to make this repository function again are very low. Please prove me wrong.

@BacLuc
Copy link

BacLuc commented Apr 11, 2021

Just yesterday I rewrote the Phpro library. I was able to make it work for my needs but I removed the ODM portion. I got rather far in the ODM unit tests but hit a point where I got stuck and, since I haven't seen anyone paying attention to this repository, I just went my own way.

I would be happy to reproduce my work with the caveat that I'll need help with the ODM unit tests. But before that can happen a decision needs to be made about what will become of the Phpro library.

I strongly recommend the Phpro library be brought under the Laminas umbrella so this library does not rely on the external dependency. Once the library exists as part of api-tools I'll submit PRs for the work I can do.

I also rewrote this library yesterday to use the rewritten Phpro library. That was not difficult with just some changes for Doctrine persistence.

https://github.com/API-Skeletons/doctrine-orm-hydration-module
https://github.com/API-Skeletons/api-tools-doctrine

To be honest my expectations of anything changing to make this repository function again are very low. Please prove me wrong.

What can be done to advance the solution of this issue?
Who decides if this library is brought under the Laminas umbrella?
Would it help if someone sponsors the migration and update of phpro/zf-doctrine-hydration-module?

@javabudd
Copy link

javabudd commented Nov 1, 2022

Is something like https://github.com/API-Skeletons/doctrine-orm-hydration-module viable or will this be brought under the Laminas project?

@TomHAnderson
Copy link
Contributor Author

https://github.com/doctrine/doctrine-laminas-hydrator is my recommended library to replace phpro. This library is maintained and up to date.

@javabudd
Copy link

javabudd commented Nov 2, 2022

Thanks @TomHAnderson, I think this issue can be closed out then. I'm working on getting a PR to replace phpro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants