Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

laminas/automatic-releases action cannot be built due to missing .git directory in the build environment #8

Closed
Ocramius opened this issue Jul 19, 2020 · 0 comments · Fixed by #10
Closed

laminas/automatic-releases action cannot be built due to missing .git directory in the build environment #8

Ocramius opened this issue Jul 19, 2020 · 0 comments · Fixed by #10
Assignees
@Ocramius
Labels
Bug Something isn't working
Milestone
1.0.0

Comments

@Ocramius
Copy link
Member

Github actions perform a docker build in an environment that is a clean export of the repository snapshot (without history), but our Dockerfile has:

automatic-releases/Dockerfile

Lines 33 to 35 in ea00621

ADD .git /app/.git
ADD bin /app/bin
ADD src /app/src

This is failing because .git doesn't exist. The .git directory is needed for ocramius/package-versions to detect the specific version of the action being built, but we can ignore this version for now.
@Ocramius Ocramius added the Bug Something isn't working label Jul 19, 2020
@Ocramius Ocramius added this to the 1.0.1 milestone Jul 19, 2020
@Ocramius Ocramius self-assigned this Jul 19, 2020
@Ocramius Ocramius mentioned this issue Jul 19, 2020
Open
Ocramius added a commit that referenced this issue Jul 19, 2020
@Ocramius
#8 #9 disable adding .git during Dockerfile steps
ef5e910 
This fixes #8, but skips version rendering in our CLI: that's
an acceptable tradeoff, for now: we'll need to fix this later,
when we work on #9 (or eventually consider dropping this code
entirely).
@Ocramius Ocramius mentioned this issue Jul 19, 2020
Merged
Ocramius added a commit that referenced this issue Jul 19, 2020
@Ocramius
Merge pull request #10 from laminas/fix/#8-remove-git-dir-from-being-…
0fc020d 
…added-to-docker-container

#8 #9 disable adding `.git` during `Dockerfile` steps
@Ocramius Ocramius modified the milestones: 1.0.1, 1.0.0 Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ocramius Ocramius

Labels
Bug Something isn't working
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

#8 #9 disable adding .git during Dockerfile steps laminas/automatic-releases
1 participant
@Ocramius