New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#11 - create+switch default branch on release #12
Conversation
Fixes #11 by providing default logic for switching to a new default branch at every release. Specifically: * when a newer release target branch exists, use that (i.e. release `1.2.3` => existing branch `1.5.x`, switch to `1.5.x`) * when a newer release branch does not exist, create it (i.e. release `1.2.3` => existing branch `1.2.x`, create `1.3.x` from `1.2.x`, use `1.3.x`) * when no release branches exist, skip entire execution TODOs: * [ ] try this out in a sandbox repository * [ ] better documentation? * [ ] update examples
Trying this out in the real world, it seems that my github actions Also tried to use a custom token, but no luck: pinging github support. |
Yep, seems like Don't know yet what the precise scope for it is. Using a custom token produced the expected results at https://github.com/Ocramius/just-trying-automated-releases/runs/888025697?check_suite_focus=true, in which, by releasing |
Confirmed with github support:
|
…o longer considered the "next major" branch This used to be an old convention of `doctrine/*` projects, and it is also gone from `doctrine/*`, where the naming will likely be adjusted to make branch target versions more clear to contributors.
…ng default branches
3426737
to
27709ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly a few questions.
Co-authored-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Co-authored-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
…er issuing a personal token with admin scope
…ajor release branch for new major releases
Fixes #11 by providing default logic for switching to a new default branch at
every release. Specifically:
1.2.3
=> existing branch1.5.x
,switch to
1.5.x
)1.2.3
=> existing branch1.2.x
,create
1.3.x
from1.2.x
, use1.3.x
)TODOs:
feature/
files)master
, which is not interesting to us anymoreNote: it would be good to get this into
1.0.0
, since it breaks BC by changing semantics around themaster
branch naming.