Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compatibility with PHP 8.2 #45

Merged
merged 3 commits into from Nov 8, 2022
Merged

Add compatibility with PHP 8.2 #45

merged 3 commits into from Nov 8, 2022

Conversation

boesing
Copy link
Member

@boesing boesing commented Nov 7, 2022

Q A
New Feature yes

Description

This also removes support for PHP 7.4
Closes #42

@boesing boesing added this to the 2.3.0 milestone Nov 7, 2022
@boesing boesing force-pushed the feature/php8.2 branch 3 times, most recently from f6d0584 to d0b117b Compare November 7, 2022 21:24
@boesing boesing mentioned this pull request Nov 7, 2022
Closed
@Ocramius Ocramius mentioned this pull request Nov 8, 2022
Merged
boesing and others added 3 commits November 8, 2022 10:23
@boesing @Ocramius
feature: add compatibility PHP 8.2
4da7ada 
This removes support for PHP 7.4

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing @Ocramius
qa: remove redundant apcu extension from .laminas-ci.json
920fa97 
This extension is now automatically parsed from the `require` section of `composer.json`.

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@Ocramius
Removed apt install make, handled in laminas/laminas-continuous-int…
024c7da 
…egration-action#138

Ref: laminas/laminas-continuous-integration-action#138
Ref: laminas/laminas-continuous-integration-action#135
@Ocramius Ocramius self-assigned this Nov 8, 2022
Ocramius
Ocramius approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Just beware: @boesing's commits were signed, and my rebase corrupted the signature (expected)

.laminas-ci/install-apcu-extension-via-pecl.sh Outdated Show resolved Hide resolved
.laminas-ci/install-apcu-extension-via-pecl.sh Outdated Show resolved Hide resolved
@Ocramius Ocramius merged commit e68fbbc into laminas:2.3.x Nov 8, 2022
@Ocramius Ocramius changed the title Add compatibility PHP 8.2 Add compatibility with PHP 8.2 Nov 8, 2022
Ocramius added a commit to laminas/laminas-cache that referenced this pull request Nov 8, 2022
@Ocramius
Copying APCu setup script from laminas/laminas-cache-storage-adapter-…
7628c89 
…apcu#45
@boesing boesing deleted the feature/php8.2 branch November 8, 2022 16:27
@Ocramius Ocramius mentioned this pull request Nov 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

@internalsystemerror internalsystemerror Awaiting requested review from internalsystemerror

Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
No open projects
PHP 8.2
Status: Done
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

laminas/laminas-cache is specified in both require AND require-dev sections of composer.json
2 participants
@boesing @Ocramius