fix #25 #26
fix #25 #26
Conversation
Bumps [laminas/laminas-cache](https://github.com/laminas/laminas-cache) from 3.0.x-dev to 3.1.2. - [Release notes](https://github.com/laminas/laminas-cache/releases) - [Commits](https://github.com/laminas/laminas-cache/commits/3.1.2) --- updated-dependencies: - dependency-name: laminas/laminas-cache dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
Thanks for this PR. Would also be great if you rebase against 2.0.x branch (I can do that as well but if you are working on it, that would be great). |
Bumps [vimeo/psalm](https://github.com/vimeo/psalm) from 4.12.0 to 4.13.0. - [Release notes](https://github.com/vimeo/psalm/releases) - [Commits](vimeo/psalm@4.12.0...4.13.0) --- updated-dependencies: - dependency-name: vimeo/psalm dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Stéphane Demonchaux <demonchaux.stephane@gmail.com>
|
@boesing : done |
There was a problem hiding this comment.
LGTM.
I must admit, that I am not even aware of the functionality of this code. We are detaching a listener from the event handler, which is always null.
So there is absolutely no chance that this code has any impact.
I wonder if this could be removed.
When looking into the previous implementation, this was related to the Filesystem#getTotalSpace method and was to reset an already detected, cached, total space value for a preconfigured directory. Not sure if the detach logic provides anything useful - but this is just for the sake of completeness here. I will create an issue from this comment for further investigation and refactoring.
|
Thanks, @fezfez! |
No description provided.